Skip to content

feature: rust-native jxl encoder#357

Merged
Gigas002 merged 8 commits into
waycrate:mainfrom
Gigas002:feature/jxl-encoder
Apr 24, 2026
Merged

feature: rust-native jxl encoder#357
Gigas002 merged 8 commits into
waycrate:mainfrom
Gigas002:feature/jxl-encoder

Conversation

@Gigas002

Copy link
Copy Markdown
Collaborator

Removed the need in libjxl dependency by switching to rust-native jxl-encoder.

Considered switching to zune-jpegxl instead, but it only supports lossless jxl.

Going to run some tests before opening this.

@Gigas002 Gigas002 requested a review from Decodetalkers April 23, 2026 04:44
@Gigas002 Gigas002 self-assigned this Apr 23, 2026
@Gigas002 Gigas002 added component: wayshot-cli dependencies Pull requests that update a dependency file labels Apr 23, 2026
@codecov-commenter

codecov-commenter commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.72%. Comparing base (f71b2ae) to head (30f32ef).

Files with missing lines Patch % Lines
wayshot/src/utils.rs 0.00% 14 Missing ⚠️
wayshot/src/config.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   16.67%   16.72%   +0.05%     
==========================================
  Files          20       20              
  Lines        3161     3151      -10     
==========================================
  Hits          527      527              
+ Misses       2634     2624      -10     
Flag Coverage Δ
libwayshot 22.04% <ø> (ø)
wayshot 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gigas002 Gigas002 added this to the 1.5.0 milestone Apr 23, 2026
@Gigas002

Copy link
Copy Markdown
Collaborator Author

Yeah looks good so far

@Gigas002 Gigas002 marked this pull request as ready for review April 23, 2026 14:41
@Decodetalkers

Copy link
Copy Markdown
Collaborator

Why the indents of yml and markdown are also changed, I think they can be separated as a new pr

@Gigas002

Copy link
Copy Markdown
Collaborator Author

Just run reformat in zed, thought it'd be too small change for a separate pr. It's already in different commit it anyway

@Decodetalkers

Copy link
Copy Markdown
Collaborator

ok

@Gigas002

Copy link
Copy Markdown
Collaborator Author

Thanks!

@Gigas002 Gigas002 merged commit 08bbb69 into waycrate:main Apr 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: wayshot-cli dependencies Pull requests that update a dependency file

Development

Successfully merging this pull request may close these issues.

3 participants